-
Notifications
You must be signed in to change notification settings - Fork 833
Update ERC-7780: Add module type 8,9,10 #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
✅ All reviewers have approved. |
eip-review-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
|
The commit 7dfab0a (as a parent of 35de140) contains errors. |
| - Policy (type id: 5) | ||
| - Signer (type id: 6) | ||
| - Stateless Validator (type id: 7) | ||
| - PreValidationHookERC1271 (type id: 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... This is a bit weird because this isn't exactly "code" in the strictest sense but putting the policy names in backticks (`) would be the easiest way to get the linter to stop complaining about "ERC1271".
My recommendation here would be to change the name to something like "Pre-Validation Hook (ERC-1271)", unless you need it to be exactly as written currently. If it's the latter case, I'd go with the backticks route (`PreValidationHookERC1271`).
eip-review-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
eip-review-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: