Skip to content

Conversation

@leekt
Copy link

@leekt leekt commented Nov 18, 2025

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Nov 18, 2025

✅ All reviewers have approved.

@eip-review-bot eip-review-bot enabled auto-merge (squash) November 18, 2025 02:43
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions
Copy link

The commit 7dfab0a (as a parent of 35de140) contains errors.
Please inspect the Run Summary for details.

- Policy (type id: 5)
- Signer (type id: 6)
- Stateless Validator (type id: 7)
- PreValidationHookERC1271 (type id: 8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... This is a bit weird because this isn't exactly "code" in the strictest sense but putting the policy names in backticks (`) would be the easiest way to get the linter to stop complaining about "ERC1271".

My recommendation here would be to change the name to something like "Pre-Validation Hook (ERC-1271)", unless you need it to be exactly as written currently. If it's the latter case, I'd go with the backticks route (`PreValidationHookERC1271`).

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants