feat: network upgrade transactions for cgt #17062
Conversation
This is WIP so far but meant to show how it can work. The big todo is to rename the feature flag with the name of the hardfork that the CGT upgrade is included in. This does leak knowledge of CGT into the client software so that it can optionally deploy the CGT predeploys. It is expected that the CGT predeploys will be in the genesis if the hardfork is active at genesis only on CGT chains. Relevant links: - ethereum-optimism/design-docs#305 - ethereum-optimism/design-docs#313 - defi-wonderland#478
| Isthmus ForkName = "isthmus" | ||
| Jovian ForkName = "jovian" | ||
| Interop ForkName = "interop" | ||
| CustomGasToken ForkName = "custom_gas_token" |
There was a problem hiding this comment.
Not exactly sure how to feature flag the best way, this cgt fork should be temporary
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
| func CustomGasTokenNetworkUpgradeTransactions() ([]hexutil.Bytes, error) { | ||
| // TODO: Implement custom gas token upgrade transactions | ||
| // Deploy controller, liquidity, set implementations, mint ETH to liquidity | ||
| upgradeTxns := make([]hexutil.Bytes, 0) | ||
| return upgradeTxns, nil | ||
| } |
There was a problem hiding this comment.
🟠 High severity: Incomplete Custom Gas Token Upgrade Implementation
Description:
The CustomGasTokenNetworkUpgradeTransactions function returns empty upgrade transactions while the system activates custom gas token functionality. This creates a state where the rollup believes custom gas token is active but no actual deployment or configuration transactions are executed.
Recommendation:
Complete the implementation of CustomGasTokenNetworkUpgradeTransactions to include all necessary deployment and configuration transactions before enabling the custom gas token feature in production.
The fix requires a more nuanced change than an inline suggestion. Fixes via PR are coming soon!
Don't like this finding? Reply "dismiss" and it won't appear again in future scans.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17062 +/- ##
============================================
- Coverage 81.88% 41.42% -40.46%
============================================
Files 161 1349 +1188
Lines 9244 108778 +99534
============================================
+ Hits 7569 45062 +37493
- Misses 1528 60424 +58896
- Partials 147 3292 +3145
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
opgitgovernance
added
the
S-stale
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
Description
This is WIP so far but meant to show how it can work. The big todo is to
rename the feature flag with the name of the hardfork that the CGT
upgrade is included in. This does leak knowledge of CGT into the client
software so that it can optionally deploy the CGT predeploys.
It is expected that the CGT predeploys will be in the genesis if
the hardfork is active at genesis only on CGT chains.
Relevant links: