Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate nibiru 7210 chain env #6709

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

cgilbe27
Copy link

@cgilbe27 cgilbe27 commented Feb 1, 2025

Deprecates 7210 and adds 6910

Copy link

github-actions bot commented Feb 1, 2025

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

@k-yang
Copy link

k-yang commented Feb 3, 2025

Chain ID 6910 is live and running for our testnet

@k-yang
Copy link

k-yang commented Feb 5, 2025

Hi, it seems that the build CI is still trying to look for chainId 7210 even though we marked that as deprecated. Should we just delete the file instead?

@cgilbe27
Copy link
Author

cgilbe27 commented Feb 5, 2025

@ligi Following up on this

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot delete chains - only mark them deprecated. This is important to prevent replay attacks

@k-yang
Copy link

k-yang commented Feb 5, 2025

Hi @ligi , we marked it as deprecated but then the build CI failed because it was expecting the old chainId (7210). What's the process for changing the chainId of a test network?

@cgilbe27 cgilbe27 requested a review from ligi February 5, 2025 19:19
@k-yang
Copy link

k-yang commented Feb 6, 2025

Hi @ligi, please advise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants