-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate nibiru 7210 chain env #6709
base: master
Are you sure you want to change the base?
chore: deprecate nibiru 7210 chain env #6709
Conversation
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
Chain ID 6910 is live and running for our testnet |
Hi, it seems that the build CI is still trying to look for chainId 7210 even though we marked that as deprecated. Should we just delete the file instead? |
@ligi Following up on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you cannot delete chains - only mark them deprecated. This is important to prevent replay attacks
Hi @ligi , we marked it as deprecated but then the build CI failed because it was expecting the old chainId (7210). What's the process for changing the chainId of a test network? |
Hi @ligi, please advise |
Deprecates 7210 and adds 6910