Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Standard Chains #6623

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

hskang9
Copy link
Contributor

@hskang9 hskang9 commented Jan 18, 2025

No description provided.

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not downgrade kotlin

@hskang9
Copy link
Contributor Author

hskang9 commented Jan 19, 2025

If I do not downgrade, the build will keep making downgrading messages, do I have to keep the current build.gradle file?

@hskang9
Copy link
Contributor Author

hskang9 commented Jan 19, 2025

It keeps showing the logs like this in build workflow.

> Configure project :model
ksp-2.0.[21](https://github.com/ethereum-lists/chains/actions/runs/12847243406/job/35823324615?pr=6623#step:4:22)-1.0.25 is too old for kotlin-2.1.0. Please upgrade ksp or downgrade kotlin-gradle-plugin to 2.0.21.
ksp-2.0.21-1.0.25 is too old for kotlin-2.1.0. Please upgrade ksp or downgrade kotlin-gradle-plugin to 2.0.21.
ksp-2.0.21-1.0.25 is too old for kotlin-2.1.0. Please upgrade ksp or downgrade kotlin-gradle-plugin to 2.0.21.
ksp-2.0.21-1.0.25 is too old for kotlin-2.1.0. Please upgrade ksp or downgrade kotlin-gradle-plugin to 2.0.21.

@hskang9
Copy link
Contributor Author

hskang9 commented Jan 19, 2025

@ligi I upgraded.

@hskang9 hskang9 requested a review from ligi January 19, 2025 01:59
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still did changes to build.gradle without any reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants