fix: updated postgre volume mount point path#124
Open
viadezo1er wants to merge 1 commit intoether:mainfrom
Open
fix: updated postgre volume mount point path#124viadezo1er wants to merge 1 commit intoether:mainfrom
viadezo1er wants to merge 1 commit intoether:mainfrom
Conversation
Postgre 18 has moved the volume mount point from /var/lib/postgresql/data to /var/lib/postgresql Fixes ether#122
Author
|
Sorry for the double PR (the other is closed), I incorrectly assumed the issue would be number 68. |
Author
|
At some point in the future, etherpad-lite might update from postgres:15-alpine to postgres:18-alpine or later, would it be relevant to add a warning in the docker-compose.yml in etherpad-lite repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgre 18 has moved the volume mount point from /var/lib/postgresql/data to /var/lib/postgresql
Fixes #122
See line 194 of the Dockerfile of postgres:18-alpine:
https://github.com/docker-library/postgres/blob/22ca5c8d8e4b37bece4d38dbce1a060583b5308a/18/alpine3.22/Dockerfile#L194
NOTE: in 18+, PGDATA has changed to match the pg_ctlcluster standard directory structure, and the VOLUME has moved from /var/lib/postgresql/data to /var/lib/postgresql
So to prevent a useless volume being created for the postgre docker each time the container is started, accordingly update the mount point of the postgre volume.
After reading the Contributor Guidelines for etherpad-lite: