Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the CLI to allow for a filename option to override the default 'routeType.ts' filename #113

Merged
merged 5 commits into from
Dec 7, 2024

Conversation

JasonPaff
Copy link
Contributor

@JasonPaff JasonPaff commented Nov 23, 2024

closes #112

This PR:

  • updates the cli to allow for a custom filename to be set under the --filename flag to replace the default of 'routeType.ts'

  • updates the examples folder with an example project that uses a custom filename (route-type.ts) for the routeType.ts files

  • updates the options section of the docs site to include --filename

  • (if ready to be merged) Yes I have made a changeset

Copy link
Owner

@ethanniser ethanniser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry im super late to this- need to fix my github notifications

thank you for the PR, this looks great except for the example does not seem to actually have the right generated file

if that is fixed I will merge

thanks again

examples/appdir-custom-filename/_next-typesafe-url_.d.ts Outdated Show resolved Hide resolved
@JasonPaff
Copy link
Contributor Author

sorry im super late to this- need to fix my github notifications

thank you for the PR, this looks great except for the example does not seem to actually have the right generated file

if that is fixed I will merge

thanks again

Sorry about that, looks like I didn't actually commit the last set of changes before opening the PR. That is now fixed!

JasonPaff and others added 4 commits December 7, 2024 13:56
- updated the examples folder with an example project that uses a custom filename for the routeType.ts files
- updated the cli to allow for a custom filename to be set under the --filename flag to replace the default of 'routeType.ts'
- updated the examples folder with an example project that uses a custom filename for the routeType.ts files
- updated the cli to allow for a custom filename to be set under the --filename flag to replace the default of 'routeType.ts'
Copy link

pkg-pr-new bot commented Dec 7, 2024

Open in Stackblitz

npm i https://pkg.pr.new/ethanniser/next-typesafe-url@113

commit: d2e9d9e

@ethanniser
Copy link
Owner

Just stripped down the example to remove duplication and fixed some formatting

Thanks for the pr

@ethanniser ethanniser merged commit 13afbf1 into ethanniser:main Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to allow the setting of a filename in the cli to be used in place of routeType.ts?
2 participants