Skip to content

Commit

Permalink
add missing 5changeset
Browse files Browse the repository at this point in the history
  • Loading branch information
Ethan Niser committed Feb 24, 2024
1 parent 0f6998f commit 3371794
Show file tree
Hide file tree
Showing 2 changed files with 1,346 additions and 1,266 deletions.
5 changes: 5 additions & 0 deletions .changeset/warm-shoes-act.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"next-typesafe-url": patch
---

revert previous change of import placements in generated .d.ts file
Loading

5 comments on commit 3371794

@lelabo-m
Copy link
Contributor

@lelabo-m lelabo-m commented on 3371794 Feb 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run into a problem with the proposed solution?
I just saw the revert patch...

If you give me the details, I may try to find another solution...

@ethanniser
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #87

does the last comment with the inline import work for you?

@lelabo-m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I did not see the related issue in the release. I took a look but will try to understand it better tomorrow.
From my side, everything seems to work fine, so I will try to understand what happened.
Thank you for giving it a shot.

@ethanniser
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for silently changing this back, I should've made sure you were tagged in the revert discussion
(I was out of town last week and saw it broke for others so just reverted without much thought)
hopefully we can figure out a solution though

@lelabo-m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I was working on something else, and it's your project. I am the one sorry for bothering you right now.

Please sign in to comment.