Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text generation #647

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Text generation #647

wants to merge 18 commits into from

Conversation

sjohn4
Copy link
Collaborator

@sjohn4 sjohn4 commented Jan 13, 2025

Took the previous feedback in mind and corrected the code.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 68.18182% with 49 lines in your changes missing coverage. Please review.

Project coverage is 85.34%. Comparing base (1a40faf) to head (082abc2).

Files with missing lines Patch % Lines
.../trainer_server/internal/dataset/online_dataset.py 64.10% 28 Missing ⚠️
modyn/models/gpt2/gpt2.py 55.00% 9 Missing ⚠️
...trainer_server/internal/trainer/pytorch_trainer.py 70.37% 8 Missing ⚠️
modyn/models/tokenizers/gpt2_tokenizer.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   85.58%   85.34%   -0.24%     
==========================================
  Files         258      261       +3     
  Lines       11378    11465      +87     
==========================================
+ Hits         9738     9785      +47     
- Misses       1640     1680      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant