Text generation #643
Open
Text generation #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dditionally, made minor updates to the environment and ensured everything passes the standard Python compliance tests, maintaining compatibility with Modyn's existing functionality.
…y have to most neccessary changes, removed unneccessary debug prints.
…o text-generation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 85.58% 85.29% -0.29%
==========================================
Files 258 260 +2
Lines 11378 11467 +89
==========================================
+ Hits 9738 9781 +43
- Misses 1640 1686 +46 ☔ View full report in Codecov by Sentry. |
MaxiBoether
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks John! Some first comments, the most important being that we should still make labels just an optional entry instead of having GetResponseNoLabels. For the next review, it would be cool if you could handle CI first, having a clean diff makes it a lot easier to review :)
modyn/storage/src/internal/file_wrapper/binary_file_wrapper.cpp
Outdated
Show resolved
Hide resolved
modyn/supervisor/internal/pipeline_executor/evaluation_executor.py
Outdated
Show resolved
Hide resolved
…o text-generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redid my changes so we do not have two branching paths.