-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: More resilient evaluations #635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, didn't see anything indicating this cannot work.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 85.61% 85.57% -0.04%
==========================================
Files 258 258
Lines 11332 11371 +39
==========================================
+ Hits 9702 9731 +29
- Misses 1630 1640 +10 ☔ View full report in Codecov by Sentry. |
This PR addresses several issues:
When the evaluator crashes with an exception, we actually also send this to the supervisor
We validate whether we receive the correct number of results at the supervisor
We fix the validation of the correct number of evaluations at the evaluator
Some minor additions of retrying to connect in case the connection gets lost
Our observation of missing evaluations should now be caught at the first point (we actually retry on exception at the evaluator) but the others serve as a guarding mechanism.