Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: More resilient evaluations #635

Merged
merged 15 commits into from
Oct 8, 2024
Merged

Conversation

MaxiBoether
Copy link
Contributor

@MaxiBoether MaxiBoether commented Sep 20, 2024

This PR addresses several issues:

  1. When the evaluator crashes with an exception, we actually also send this to the supervisor

  2. We validate whether we receive the correct number of results at the supervisor

  3. We fix the validation of the correct number of evaluations at the evaluator

  4. Some minor additions of retrying to connect in case the connection gets lost

Our observation of missing evaluations should now be caught at the first point (we actually retry on exception at the evaluator) but the others serve as a guarding mechanism.

Copy link
Collaborator

@robinholzi robinholzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, didn't see anything indicating this cannot work.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 78.65169% with 19 lines in your changes missing coverage. Please review.

Project coverage is 85.57%. Comparing base (a15b3c6) to head (404e0de).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
modyn/supervisor/internal/grpc_handler.py 58.06% 13 Missing ⚠️
.../internal/pipeline_executor/evaluation_executor.py 92.30% 3 Missing ⚠️
...n/supervisor/internal/triggers/datadrifttrigger.py 0.00% 2 Missing ⚠️
...evaluator/internal/grpc/evaluator_grpc_servicer.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   85.61%   85.57%   -0.04%     
==========================================
  Files         258      258              
  Lines       11332    11371      +39     
==========================================
+ Hits         9702     9731      +29     
- Misses       1630     1640      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxiBoether MaxiBoether merged commit 6436929 into main Oct 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants