-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dimensionality issue when binary classification outputs 1D instead of 2D tensor #609
Fix dimensionality issue when binary classification outputs 1D instead of 2D tensor #609
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 85.60% 85.62% +0.02%
==========================================
Files 258 258
Lines 11311 11327 +16
==========================================
+ Hits 9683 9699 +16
Misses 1628 1628 ☔ View full report in Codecov by Sentry. |
...iner_server/internal/trainer/remote_downsamplers/remote_uncertainty_downsampling_strategy.py
Show resolved
Hide resolved
modyn/trainer_server/internal/trainer/remote_downsamplers/remote_gradnorm_downsampling.py
Show resolved
Hide resolved
...er_server/internal/trainer/remote_downsamplers/test_abstract_matrix_downsampling_strategy.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This mostly looks good, I had a couple of clarification comments and suggestions.
...iner_server/internal/trainer/remote_downsamplers/remote_uncertainty_downsampling_strategy.py
Outdated
Show resolved
Hide resolved
modyn/trainer_server/internal/trainer/remote_downsamplers/remote_gradnorm_downsampling.py
Show resolved
Hide resolved
...trainer_server/internal/trainer/remote_downsamplers/abstract_matrix_downsampling_strategy.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Xianzhe! This LGTM!
For binary classification (e.g. DLRM), there are two problems:
This PR adapts the existing downsamplers to the binary classfication.