Skip to content

Commit

Permalink
grpc 1.64.3 instead of 1.69
Browse files Browse the repository at this point in the history
  • Loading branch information
MaxiBoether committed Jan 8, 2025
1 parent 1c14103 commit d765245
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmake/storage_dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ if((NOT MODYN_TRY_LOCAL_GRPC) OR (NOT gRPC_FOUND))
FetchContent_Declare(
gRPC
GIT_REPOSITORY https://github.com/grpc/grpc
GIT_TAG v1.69.0 # When updating this, make sure to also update the modynbase dockerfile
GIT_TAG v1.64.3 # When updating this, make sure to also update the modynbase dockerfile
GIT_SHALLOW TRUE
)
set(gRPC_BUILD_TESTS OFF CACHE BOOL "" FORCE)
Expand Down
2 changes: 1 addition & 1 deletion docker/Dependencies/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ RUN echo "Used buildtype is ${MODYN_BUILDTYPE}" >> /src/.modyn_buildtype
RUN echo "Used dependency buildtype is ${MODYN_DEP_BUILDTYPE}" >> /src/.modyn_dep_buildtype

# Install gRPC systemwide. When updating the version, make sure to also update the storage_dependencies.cmake file
RUN git clone --recurse-submodules -b v1.69.0 --depth 1 --shallow-submodules https://github.com/grpc/grpc && \
RUN git clone --recurse-submodules -b v1.64.3 --depth 1 --shallow-submodules https://github.com/grpc/grpc && \
cd grpc && mkdir -p cmake/build && cd cmake/build && \
cmake -DgRPC_PROTOBUF_PROVIDER=module -DABSL_ENABLE_INSTALL=On -DgRPC_BUILD_CSHARP_EXT=Off -DABSL_BUILD_TESTING=Off -DgRPC_INSTALL=ON -DgRPC_BUILD_TESTS=OFF -DCMAKE_BUILD_TYPE=${MODYN_DEP_BUILDTYPE} ../.. && \
make -j8 && make install && cd ../../
Expand Down

0 comments on commit d765245

Please sign in to comment.