use release mode in Dockerfile and do not use gcc12 RELEASE

eth-easl · Oct 18, 2023 · 6f6750c · 6f6750c
1 parent 0b31c57
commit 6f6750c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/workflow.yaml b/.github/workflows/workflow.yaml
@@ -157,7 +157,6 @@ jobs:
         compiler:
           - { c: gcc, cxx: g++, version: 11 }
           - { c: gcc, cxx: g++, version: 12 }
-          - { c: gcc, cxx: g++, version: 13 }
           - { c: clang, cxx: clang++, version: 14 }
           - { c: clang, cxx: clang++, version: 16, coverage: true }
         include:
@@ -167,6 +166,11 @@ jobs:
             build-type: Tsan
           - compiler: {c: clang, cxx: clang++, version: 14}
             build-type: Asan
+        exclude:
+          # gcc-12 causes a false-positive memory error in release (https://github.com/google/googletest/issues/4108)
+          - os: { c: gcc, cxx: g++, version: 12 }
+            build-type: Release
+
     env:
       CC: ${{matrix.compiler.c}}-${{matrix.compiler.version}}
       CXX: ${{matrix.compiler.cxx}}-${{matrix.compiler.version}}

diff --git a/docker/Storage/Dockerfile b/docker/Storage/Dockerfile
@@ -5,7 +5,7 @@ RUN cmake --version
 
 RUN mkdir -p ./modyn/storage/build \
     && cd ./modyn/storage/build \
-    && cmake .. \
+    && cmake .. -DCMAKE_BUILD_TYPE=Release \
     && make -j8
 
 # During debugging, this entry point will be overridden. For more information, please refer to https://aka.ms/vscode-docker-python-debug