Skip to content

Clarify second entry for arm on supported platforms table #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2025
Merged

Clarify second entry for arm on supported platforms table #1055

merged 2 commits into from
Sep 3, 2025
+3 −6

Conversation

ABin-Huang
Copy link
Contributor

Updated supported-platform.md in v3.5 and v3.6.

@k8s-ci-robot
Copy link

Hi @ABin-Huang. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ABin-Huang ABin-Huang force-pushed the fix/update_file_content branch from ab8519b to 4761515 Compare August 21, 2025 15:39
@ivanvc
Copy link
Member

ivanvc commented Aug 22, 2025

Link to #739.

Hi, @ABin-Huang. Thanks for your pull request. Could you please also check #1030? Because even though "ARM" was listed, we don't build binaries for it. That later issue is more accurate regarding what should be in the table.

Thanks again :)

@ivanvc
Copy link
Member

ivanvc commented Aug 22, 2025

/ok-to-test

@ABin-Huang
Copy link
Contributor Author

@ivanvc Ok, I'll take a look at the specific content and modify it.

@ABin-Huang ABin-Huang force-pushed the fix/update_file_content branch from 20a5213 to 4761515 Compare August 22, 2025 08:14
@ABin-Huang
Copy link
Contributor Author

I have submitted it, please review whether to handle it this way

wendy-ha18
wendy-ha18 reviewed Aug 27, 2025
View reviewed changes
wendy-ha18
wendy-ha18 reviewed Aug 27, 2025
View reviewed changes
@wendy-ha18
Copy link
Contributor

We haven't release 3.7 but because we're updating supported-platform.md page in docs for v3.5 and v3.6, do you think we should update for v3.7 as well @jberkus ?

@wendy-ha18
Copy link
Contributor

wendy-ha18 commented Aug 28, 2025 •
edited
Loading

Me and Josh just had a discussion about this PR for v3.7, even it's in Draft but @ABin-Huang , could you please also help me update it similiar with v3.6 (cause we haven't had plan for release 3.7 yet but we shouldn't leave it inaccurate as well).

@ABin-Huang
Copy link
Contributor Author

ABin-Huang commented Aug 31, 2025 •
edited
Loading

@wendy-ha18 hello, I have completed the repair of "ARM-related entries in the table of explicitly supported platforms":

  1. For the supported-platform.md of v3.5/v3.6, the actually unsupported items of ARM(32-bit) and AMD32/386 architecture are removed to avoid misleading documents;
  2. According to the feedback, the item "ARM64 Darwin Tier 3 Support" in v3.6 is supplemented to match the actually released binary package;
  3. v3.7 and v3.6 are consistent.

wendy-ha18
wendy-ha18 reviewed Aug 31, 2025
View reviewed changes
@ivanvc
Copy link
Member

ivanvc commented Sep 2, 2025

Thanks for the changes, @ABin-Huang. Could you please squash your commits into a single one? Thanks, again :)

@ABin-Huang
add ARM64 Darwin (Tier 3 Support) to the table in v3.5
3ad76a1 
Signed-off-by: abin <[email protected]>

Update the table in version 3.7 to make it similar to version 3.6.

Signed-off-by: abin <[email protected]>

Add ARM64 Darwin (Tier 3 Support) to the table.

Signed-off-by: abin <[email protected]>

Remove ARM Linux (Tier 3 Support) from the table.

Signed-off-by: abin <[email protected]>

remove ARM and 386 Architecture content/en/docs/v3.6/op-guide/supported-platform.md(etcd-io#1030)

Signed-off-by: abin <[email protected]>

Update content/en/docs/v3.6/op-guide/supported-platform.md (etcd-io#739)

Signed-off-by: abin <[email protected]>

Update content/en/docs/v3.5/op-guide/supported-platform.md (etcd-io#739)

Signed-off-by: abin <[email protected]>
@ABin-Huang ABin-Huang force-pushed the fix/update_file_content branch from 8b7c6dc to 3ad76a1 Compare September 3, 2025 11:52
@ABin-Huang
Copy link
Contributor Author

Thanks for the changes, @ABin-Huang. Could you please squash your commits into a single one? Thanks, again :)

ok

@wendy-ha18
Copy link
Contributor

/lgtm
thanks @ABin-Huang

@wendy-ha18 wendy-ha18 removed their assignment Sep 3, 2025
ivanvc
ivanvc approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Thanks, @ABin-Huang!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ABin-Huang, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc ivanvc merged commit 63d50e3 into etcd-io:main Sep 3, 2025
6 checks passed
This was referenced Sep 3, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc approved these changes

+1 more reviewer

@wendy-ha18 wendy-ha18 wendy-ha18 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ABin-Huang @k8s-ci-robot @ivanvc @wendy-ha18