Skip to content

Conversation

webdawg
Copy link

@webdawg webdawg commented Jun 3, 2025

please be gentle

related issue #903

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: webdawg
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @webdawg. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jberkus
Copy link
Contributor

jberkus commented Jun 5, 2025

/ok-to-test

@jberkus
Copy link
Contributor

jberkus commented Jun 5, 2025

@ivanvc @jmhbnz @spzala defer to you on this one.

@ronaldngounou
Copy link
Member

ronaldngounou commented Jun 8, 2025

@webdawg

  1. To pass the DCO check, you have to signoff your commit off all your commit to always include Signed-off-by: Author Name [email protected] in every commit message.
    You can also do this automatically by using the -s flag (i.e., git commit -s).

  2. Could you please elaborate on the testing you have done to achive a successful execution of thi script and add it to the PR description ?

@jberkus
Copy link
Contributor

jberkus commented Jul 8, 2025

Also: this is the version of the script to create a config file. The one that belongs in /website should be the version that generates the output for configuration.md. They'd both be pretty similar -- or even one script with switches -- but that's what we need in this location.

Copy link
Contributor

@jberkus jberkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes per prior comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants