raft,tracker: track follower commit index #132
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pav-kv
force-pushed
the
track-commit-index
branch
7 times, most recently
from
196927d to
e85d630
Compare
pav-kv
changed the title
pav-kv
force-pushed
the
track-commit-index
branch
2 times, most recently
from
bbedbac to
8e5b410
Compare
pav-kv
force-pushed
the
track-commit-index
branch
4 times, most recently
from
7c2e0fc to
3723231
Compare
pav-kv
changed the title
When we send a snapshot, this is equivalent to sending all entries up to the snapshot's index. Correspondingly, we update the Next index to reflect this in-flight state. Signed-off-by: Pavel Kalinnikov <[email protected]>
This commit adds a Progress.pendingCommit field tracking the highest commit index <= Next-1 which the leader sent to the follower. It is used to distinguish cases when a commit index update needs or doesn't need to be sent to a follower. Signed-off-by: Pavel Kalinnikov <[email protected]>
Signed-off-by: Pavel Kalinnikov <[email protected]>
This commit closes a gap in commit index tracking. Previously, the leader did not precisely know what commit index the follower is at, and always had to send an empty MsgApp to brind it up to date if it's not. With this commit, followers now send the commit index of their logs back to the leader, and the leader tracks each follower's commit index. This will allow the leader (see other commits) to send an empty MsgApp with a commit index update only if the tracked index is behind, which will reduce the number of unnecessary messages in the system. Signed-off-by: Pavel Kalinnikov <[email protected]>
Signed-off-by: Pavel Kalinnikov <[email protected]>
pav-kv
force-pushed
the
track-commit-index
branch
from
3723231 to
e246b8d
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes a gap in commit index tracking, and reduces the number of unnecessary
MsgAppmessages in the system.Previously, the leader did not precisely know what commit index the follower is at, and always had to send an empty
MsgAppto bring it up to date if it's not.With this change, followers now send the commit index of their logs back to the leader, and the leader tracks each follower's commit index. This allows the leader to send an empty
MsgAppwith a commit index update only if the tracked index is behind.Resolves #131