-
Notifications
You must be signed in to change notification settings - Fork 46
Add elbehery to OWNERS #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Elbehery The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mustafa Elbehery <[email protected]>
af28c94
to
5716db3
Compare
Thanks for initiative, please read the etcd requirements for becoming a reviewer https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/community-membership.md#reviewers |
@Elbehery as we discussed in the community meeting, please read the membership guide as mentioned in #116 (comment) (also mentioned above by @serathius ) For the gofail project/tool, AFAIK we don't have any new TODO features for now, so we don't have opportunity to evaluate the contributor's knowledge on the project by his/her work (i.e PRs). We will have to depend on the existing maintainer's judgement/evaluation. @Elbehery please read the design I provided in #116 (comment) and spend some time to under the internal mechanism of the project. I am happy to have 1:1 talk to evaluate your understanding on the project later. Please anyone let me know if you have better way to proceed. For now, we have regular (weekly) dependencies bumping PRs and also golang version bumping PRs, we need maintainers/reviews to take care of them. We might have enhancement in future. We also need maintainers to respond to PRs/issues. We should encourage & help people to grow into an approver or reviewer role (being review first, and approver later). So proposal to @Elbehery :
|
Thanks for your review 🙏🏽 .. Will go through it in details 👍🏽 |
Thanks so much for your guidance, yes indeed, will go through the docs && code-base and will notify you once I am ready for the 1:1 discussion 🙏🏽 🙏🏽 🙏🏽 |
Reference:
cc @ahrtr @ivanvc @jmhbnz