-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add a new metrics etcd_server_request_duration_seconds to track e2e duration for each request #21038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bb11472 to
96054ff
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 25 files with indirect coverage changes @@ Coverage Diff @@
## main #21038 +/- ##
==========================================
+ Coverage 68.39% 68.42% +0.03%
==========================================
Files 429 429
Lines 35213 35291 +78
==========================================
+ Hits 24083 24149 +66
- Misses 9721 9739 +18
+ Partials 1409 1403 -6 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| return "ClusterMemberAttrSet" | ||
| case r.DowngradeInfoSet != nil: | ||
| return "DowngradeInfoSet" | ||
| case r.DowngradeVersionTest != nil: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should have DowngradeCancel + DowngradeEnable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DowngradeCancel and DowngradeEnable are already included in DowngradeInfoSet. We don't have to differentiate them.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…uration for each request Signed-off-by: Benjamin Wang <[email protected]>
96054ff to
9cdb1cf
Compare
|
@ahrtr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
thx @fuweid for quick review. @ivanvc @serathius @tjungblu PTAL. Also I think this metric is important for debugging etcd performance, such as QPS and request latency. Would you be OK with backporting this PR to the stable 3.5 and 3.6 releases? I don’t intend to insist, but I think it would be better to backport. |
Fix #21036
Eventually we may need to deprecate
etcd_server_range_duration_seconds.cc @lavacat @fuweid @ivanvc @serathius
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.