Add more extensive runtime metrics #21029
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tjungblu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 23 files with indirect coverage changes @@ Coverage Diff @@
## main #21029 +/- ##
==========================================
+ Coverage 69.18% 69.23% +0.05%
==========================================
Files 422 422
Lines 34841 34843 +2
==========================================
+ Hits 24104 24124 +20
+ Misses 9335 9319 -16
+ Partials 1402 1400 -2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
I've noticed that K8s and apiserver contains several metrics that etcd does not have. This PR adds the missing metrics to the default Prometheus registry. Signed-off-by: Thomas Jungblut <[email protected]>
tjungblu
force-pushed
the
gogc_metrics
branch
from
d418c87 to
1e457e3
Compare
|
/retest |
|
@tjungblu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| func init() { | ||
| // register more extensive go runtime metrics, for that we need to unregister the default metrics first | ||
| prometheus.Unregister(collectors.NewGoCollector()) |
There was a problem hiding this comment.
I haven't diged into the implementation of prometheus.Unregister, but you unregister a newly created objerct collectors.NewGoCollector() instead of the existing already registered one, are you sure it's correct?
4 participants
I've noticed that K8s and apiserver contains several metrics that etcd does not have. This PR adds the missing metrics to the default Prometheus registry.