Skip to content

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Sep 1, 2025

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The lease might have been revoked during renew process (right after previous check).

I will add an e2e test to reproduce the issue later.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.19%. Comparing base (963a72e) to head (6d51f4b).

Files with missing lines Patch % Lines
server/lease/lessor.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/lease/lessor.go 88.65% <25.00%> (-0.67%) ⬇️

... and 44 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20590      +/-   ##
==========================================
+ Coverage   67.91%   69.19%   +1.28%     
==========================================
  Files         419      420       +1     
  Lines       34762    34780      +18     
==========================================
+ Hits        23608    24066     +458     
+ Misses       9763     9318     -445     
- Partials     1391     1396       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963a72e...6d51f4b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@silentred
Copy link
Contributor

silentred commented Sep 4, 2025

make sense. lessor.Revoke is also protected by le.mu

etcd/server/lease/lessor.go

Lines 353 to 355 in 21d04d7

le.mu.Lock()
defer le.mu.Unlock()
delete(le.leaseMap, l.ID)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants