tcpproxy: Refactor, fix bugs and potential panics #20583
+50
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
tcpproxy
package and fixes some bugs and panics:atomic.Bool
forremote.inactive
instead of a mutex to improve performance and reduce struct sizestrconv.Itoa
for int-to-string conversion instead offmt.Sprintf
for better performanceuint64
forpickCount
to avoid overflow issuesStop
to prevent panic when stopping beforeRun
or closing an already closed channel