server/embed: Log EOF on DEBUG in TLS handshake #20568
Conversation
When EOF is encountered during TLS handshake, it is still logged as a warning. This seems excessive and not really useful. This patch ensures EOF is logged on debug only. Unit tests are also added, but since the handler doesn't use an interface for passing the TLS connection in, mocking that is hard. It's achieved by using a private global variable, which is really not ideal, but given the situation, it's the best tradeoff between the code being pretty and complex. Signed-off-by: Ondra Kupka <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tchap The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @tchap. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When EOF is encountered during TLS handshake, it is still logged as a warning. This seems excessive and not really useful.
This patch ensures EOF is logged on debug only.
Unit tests are also added, but since the handler doesn't use an interface for passing the TLS connection in, mocking that is hard. It's achieved by using a private global variable, which is really not ideal, but given the situation, it's the best tradeoff between the code being pretty and complex.
Fixes #20565