Skip to content

Conversation

nwnt
Copy link
Member

@nwnt nwnt commented Aug 20, 2025

As a follow up of #20457, this registers the raftDropHeartbeat failpoint.

cc @serathius

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@26dc1bc). Learn more about missing BASE report.
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20520   +/-   ##
=======================================
  Coverage        ?   69.34%           
=======================================
  Files           ?      419           
  Lines           ?    34745           
  Branches        ?        0           
=======================================
  Hits            ?    24094           
  Misses          ?     9266           
  Partials        ?     1385           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26dc1bc...f345957. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius
Copy link
Member

Awesome work! Thank you for finishing the failpoint improvements.

Unfortunately we started getting a lot of flakes.
/retest

@k8s-ci-robot
Copy link

k8s-ci-robot commented Aug 20, 2025

@nwnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-grpcproxy-integration-amd64 f345957 link true /test pull-etcd-grpcproxy-integration-amd64
pull-etcd-integration-4-cpu-amd64 f345957 link true /test pull-etcd-integration-4-cpu-amd64
pull-etcd-coverage-report f345957 link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

QQ, have you confirmed that RaftDropHeartbeat failpoint is triggered? For gofailSleepAndDeactivate we don't have a way to confirm that failpoint was really triggered. The issue #14729 was dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants