-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Register raftDropHeartbeat failpoint #20520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nont <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20520 +/- ##
=======================================
Coverage ? 69.34%
=======================================
Files ? 419
Lines ? 34745
Branches ? 0
=======================================
Hits ? 24094
Misses ? 9266
Partials ? 1385 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Awesome work! Thank you for finishing the failpoint improvements. Unfortunately we started getting a lot of flakes. |
@nwnt: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
QQ, have you confirmed that |
As a follow up of #20457, this registers the raftDropHeartbeat failpoint.
cc @serathius