Skip to content

Conversation

Elbehery
Copy link
Member

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Elbehery Elbehery requested a review from ahrtr July 23, 2025 23:36
@Elbehery Elbehery force-pushed the 20250724_cleanup_v2store branch 3 times, most recently from 0cb411e to a842267 Compare July 24, 2025 00:17
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 0% with 164 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.87%. Comparing base (cb7e990) to head (7aadc03).
⚠️ Report is 204 commits behind head on main.

Files with missing lines Patch % Lines
etcdutl/etcdutl/check_command.go 0.00% 163 Missing ⚠️
etcdutl/ctl.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
etcdutl/ctl.go 0.00% <0.00%> (ø)
etcdutl/etcdutl/check_command.go 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20393      +/-   ##
==========================================
- Coverage   69.11%   68.87%   -0.24%     
==========================================
  Files         415      416       +1     
  Lines       34630    34794     +164     
==========================================
+ Hits        23934    23964      +30     
- Misses       9302     9438     +136     
+ Partials     1394     1392       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7e990...7aadc03. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Mustafa Elbehery <[email protected]>
@Elbehery Elbehery force-pushed the 20250724_cleanup_v2store branch from a842267 to 7aadc03 Compare July 24, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants