Create a MembershipBackend interface to fix unexported-return #19343
Conversation
Signed-off-by: adeyemi <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aladesawe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @aladesawe. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Pulled from PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 56 files with indirect coverage changes @@ Coverage Diff @@
## main #19343 +/- ##
==========================================
+ Coverage 68.79% 68.83% +0.03%
==========================================
Files 420 420
Lines 35629 35716 +87
==========================================
+ Hits 24510 24584 +74
- Misses 9700 9706 +6
- Partials 1419 1426 +7 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
| type MembershipBackend interface { | ||
| MustSaveMemberToBackend(m *membership.Member) | ||
| TrimClusterFromBackend() error | ||
| MustDeleteMemberFromBackend(id types.ID) | ||
| MustReadMembersFromBackend() (map[types.ID]*membership.Member, map[types.ID]bool) | ||
| TrimMembershipFromBackend() error | ||
| MustSaveClusterVersionToBackend(ver *semver.Version) | ||
| MustSaveDowngradeToBackend(downgrade *version.DowngradeInfo) | ||
| MustCreateBackendBuckets() | ||
| ClusterVersionFromBackend() *semver.Version | ||
| DowngradeInfoFromBackend() *version.DowngradeInfo | ||
| } |
There was a problem hiding this comment.
It's duplicated to
etcd/server/etcdserver/api/membership/store.go
Lines 27 to 32 in f1d09c0
Again, the simplest solution is to move it into storage/schema
There was a problem hiding this comment.
@ahrtr do we want to import into schema versus moving it to schema? There's been no exported interface definition in schema
aladesawe
changed the title
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.