-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 3.4 changelog to cover the goroutine leakage issue #18824
Conversation
Signed-off-by: Benjamin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18824 +/- ##
==========================================
+ Coverage 68.76% 68.86% +0.10%
==========================================
Files 420 420
Lines 35523 35523
==========================================
+ Hits 24426 24464 +38
+ Misses 9665 9638 -27
+ Partials 1432 1421 -11 Continue to review full report in Codecov by Sentry.
|
/test pull-etcd-robustness-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Benjamin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ahrtr
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previous PR forgot to update 3.4 changelog.