Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.4 changelog to cover the goroutine leakage issue #18824

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Nov 1, 2024

Previous PR forgot to update 3.4 changelog.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (3de0018) to head (277afc7).

Current head 277afc7 differs from pull request most recent head 3bacd02

Please upload reports for the commit 3bacd02 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18824      +/-   ##
==========================================
+ Coverage   68.76%   68.86%   +0.10%     
==========================================
  Files         420      420              
  Lines       35523    35523              
==========================================
+ Hits        24426    24464      +38     
+ Misses       9665     9638      -27     
+ Partials     1432     1421      -11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de0018...3bacd02. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Nov 1, 2024

/test pull-etcd-robustness-amd64

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Benjamin.

@ahrtr ahrtr deleted the changelog_20241101 branch November 3, 2024 09:42
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 98e53e5 into etcd-io:main Nov 3, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants