-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): extend TestNoErrorLogsDuringNormalOperations with different TLS configs #18819
Conversation
…nt TLS configs Signed-off-by: Thomas Gosteli <[email protected]>
Hi @ghouscht. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18819 +/- ##
==========================================
- Coverage 68.74% 68.73% -0.02%
==========================================
Files 420 420
Lines 35523 35523
==========================================
- Hits 24422 24418 -4
- Misses 9673 9679 +6
+ Partials 1428 1426 -2 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Looks good, long term would be good to combine the list of scenarios with Lines 31 to 53 in 3de0018
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ghouscht, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See #17329 (comment) for details. This PR adds three additional test cases, each with different TLS settings.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.