Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable errorlint linter #18818

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

This enable errorlint in golangci-lint config file

Related to #18576

Signed-off-by: Matthieu MOREL <[email protected]>
@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35
Copy link
Contributor Author

/assign @ahrtr

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (ee88ecc) to head (7d7c6c5).

Current head 7d7c6c5 differs from pull request most recent head e5a6348

Please upload reports for the commit e5a6348 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 18 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18818   +/-   ##
=======================================
  Coverage   68.74%   68.74%           
=======================================
  Files         420      420           
  Lines       35523    35523           
=======================================
  Hits        24422    24422           
+ Misses       9673     9671    -2     
- Partials     1428     1430    +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee88ecc...e5a6348. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Oct 31, 2024

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented Oct 31, 2024

/retest

@mmorel-35
Copy link
Contributor Author

As this enables errorlint it might even be able to close #18576

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mmorel-35.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 995027f into etcd-io:main Nov 3, 2024
39 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/errorlint branch November 3, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants