Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Etcdserver.snapshot to extract compaction into a separate method #18808

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 30, 2024

Since nobody proceeds with the proposal, so create a followup PR to https://github.com/etcd-io/etcd/pull/18635/files#r1778755879

cc @clement2026 @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (36d785d) to head (976e9ee).
Report is 12 commits behind head on main.

Current head 976e9ee differs from pull request most recent head 694b0fb

Please upload reports for the commit 694b0fb to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/server.go 81.32% <100.00%> (-0.11%) ⬇️

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18808      +/-   ##
==========================================
- Coverage   68.81%   68.75%   -0.07%     
==========================================
  Files         420      420              
  Lines       35512    35515       +3     
==========================================
- Hits        24437    24417      -20     
- Misses       9647     9669      +22     
- Partials     1428     1429       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d785d...694b0fb. Read the comment docs.

@ahrtr ahrtr merged commit a654cde into etcd-io:main Oct 30, 2024
32 checks passed
@ahrtr ahrtr deleted the refactor_snapshot_20240927 branch October 30, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants