Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] chore(e2e): backport TestNoErrorLogsDuringNormalOperations test #18807

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ghouscht
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @ghouscht. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ghouscht ghouscht force-pushed the backport-3.5-no-error-logs-test branch from 1dfe1ff to 5ec08a2 Compare October 30, 2024 09:50
@ghouscht ghouscht marked this pull request as ready for review October 30, 2024 09:50
@ivanvc
Copy link
Member

ivanvc commented Oct 30, 2024

/retitle [3.5] chore(e2e): backport TestNoErrorLogsDuringNormalOperations test
/ok-to-test

@k8s-ci-robot k8s-ci-robot changed the title chore(e2e): backport TestNoErrorLogsDuringNormalOperations test [3.5] chore(e2e): backport TestNoErrorLogsDuringNormalOperations test Oct 30, 2024
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

{
name: "single node cluster",
clusterSize: 1,
allowedErrors: map[string]bool{},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not get time to dig out why 3.5 doesn't see the error message as 3.6. Did you ever dig into it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, ghouscht, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 1b88fc4 into etcd-io:release-3.5 Oct 30, 2024
26 checks passed
@ghouscht ghouscht deleted the backport-3.5-no-error-logs-test branch October 31, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants