-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use require instead of t.Fatal(err) in tests/robustness package #18782
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @spzala |
c93c6f2
to
7d2388a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18782 +/- ##
==========================================
+ Coverage 68.74% 68.77% +0.03%
==========================================
Files 420 420
Lines 35512 35512
==========================================
+ Hits 24411 24425 +14
+ Misses 9671 9658 -13
+ Partials 1430 1429 -1 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
/retest |
1 similar comment
/retest |
Signed-off-by: Matthieu MOREL <[email protected]>
7d2388a
to
4017eba
Compare
/test pull-etcd-integration-1-cpu-amd64 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is no linter for this.
This uses testify instead of testing for t.Fatal calls