Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tenv linter #18774

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 24, 2024

Tenv is an analyzer that detects using os.Setenv instead of t.Setenv since Go1.17.

enables and fixes tenv linter issues

Signed-off-by: Matthieu MOREL <[email protected]>
@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 44.11765% with 38 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (ac3d5d7) to head (f683b3b).
Report is 33 commits behind head on main.

Current head f683b3b differs from pull request most recent head 048fd57

Please upload reports for the commit 048fd57 to get more accurate results.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/global.go 0.00% 12 Missing ⚠️
etcdctl/ctlv3/command/make_mirror_command.go 0.00% 10 Missing ⚠️
client/v3/mock/mockserver/mockserver.go 0.00% 4 Missing ⚠️
client/v3/snapshot/v3_snapshot.go 0.00% 2 Missing ⚠️
etcdctl/ctlv3/ctl.go 0.00% 2 Missing ⚠️
pkg/netutil/netutil.go 50.00% 2 Missing ⚠️
client/v3/client.go 80.00% 0 Missing and 1 partial ⚠️
client/v3/experimental/recipes/key.go 50.00% 1 Missing ⚠️
client/v3/leasing/kv.go 50.00% 0 Missing and 1 partial ⚠️
client/v3/maintenance.go 66.66% 1 Missing ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
client/v3/config.go 85.45% <100.00%> (+0.54%) ⬆️
client/v3/lease.go 90.17% <100.00%> (-0.71%) ⬇️
client/v3/retry.go 79.48% <100.00%> (+0.17%) ⬆️
client/v3/retry_interceptor.go 65.61% <100.00%> (ø)
client/v3/watch.go 93.83% <100.00%> (ø)
pkg/expect/expect.go 79.12% <100.00%> (ø)
pkg/featuregate/feature_gate.go 87.66% <100.00%> (ø)
pkg/flags/flag.go 68.57% <100.00%> (ø)
server/storage/mvcc/testutil/hash.go 83.78% <100.00%> (ø)
client/v3/client.go 84.93% <80.00%> (+0.04%) ⬆️
... and 11 more

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18774      +/-   ##
==========================================
+ Coverage   68.74%   68.77%   +0.02%     
==========================================
  Files         420      420              
  Lines       35481    35508      +27     
==========================================
+ Hits        24393    24422      +29     
- Misses       9656     9659       +3     
+ Partials     1432     1427       -5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c8869...048fd57. Read the comment docs.

@mmorel-35
Copy link
Contributor Author

/assign @jmhbnz

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmorel-35, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

This is awesome improvement.

@serathius serathius merged commit c2261ef into etcd-io:main Oct 24, 2024
18 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/tenv branch October 24, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants