-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable tenv linter #18774
fix: enable tenv linter #18774
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18774 +/- ##
==========================================
+ Coverage 68.74% 68.77% +0.02%
==========================================
Files 420 420
Lines 35481 35508 +27
==========================================
+ Hits 24393 24422 +29
- Misses 9656 9659 +3
+ Partials 1432 1427 -5 Continue to review full report in Codecov by Sentry.
|
/assign @jmhbnz |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmorel-35, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is awesome improvement. |
Tenv is an analyzer that detects using os.Setenv instead of t.Setenv since Go1.17.
enables and fixes tenv linter issues