Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to clarify non-f-functions on golang standard lib #18766

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 22, 2024

Followup to #18741

Refer to #18741 (comment)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (bb381d4) to head (1e2c07a).

Current head 1e2c07a differs from pull request most recent head 9060226

Please upload reports for the commit 9060226 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18766      +/-   ##
==========================================
+ Coverage   68.68%   68.81%   +0.13%     
==========================================
  Files         420      420              
  Lines       35504    35504              
==========================================
+ Hits        24385    24432      +47     
+ Misses       9685     9645      -40     
+ Partials     1434     1427       -7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb381d4...9060226. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Oct 22, 2024

/test pull-etcd-integration-1-cpu-amd64

1 similar comment
@ahrtr
Copy link
Member Author

ahrtr commented Oct 22, 2024

/test pull-etcd-integration-1-cpu-amd64

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Ben.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 4b59ec1 into etcd-io:main Oct 23, 2024
34 checks passed
@ahrtr ahrtr deleted the f_functions_20241022 branch October 23, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants