-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable gofumpt instead of gofmt linter in contrib, etcdctl and etcdutl #18754
base: main
Are you sure you want to change the base?
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 22 files with indirect coverage changes @@ Coverage Diff @@
## main #18754 +/- ##
=======================================
Coverage 68.76% 68.76%
=======================================
Files 420 420
Lines 35523 35524 +1
=======================================
+ Hits 24426 24427 +1
- Misses 9665 9668 +3
+ Partials 1432 1429 -3 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is no suggested assignee here. |
9791d81
to
79e6169
Compare
/retest |
/assign @ahrtr |
79e6169
to
b519548
Compare
/retest |
/test pull-etcd-integration-1-cpu-amd64 |
…tcdutl Signed-off-by: Matthieu MOREL <[email protected]>
/test pull-etcd-integration-2-cpu-amd64 |
b519548
to
f4563ee
Compare
f0c5fdd
to
97e4699
Compare
enables and fixes gofumpt linter issues in contrib, etcdctl and etcdutl directories