Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: remove ARM integration jobs #18714

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Oct 11, 2024

After merging kubernetes/test-infra#33525 and kubernetes/test-infra#33626, removing the integration ARM jobs should be fine. These are the last ARM jobs, and finalizes the main branch's ARM migration to the prow infrastructure 🎉

Part of kubernetes/test-infra#32754 / kubernetes/k8s.io#6102

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code size/M labels Oct 11, 2024
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for driving this @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (133918e) to head (7e3a581).

Current head 7e3a581 differs from pull request most recent head 9e6341f

Please upload reports for the commit 9e6341f to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18714      +/-   ##
==========================================
- Coverage   68.75%   68.73%   -0.02%     
==========================================
  Files         420      420              
  Lines       35494    35494              
==========================================
- Hits        24404    24397       -7     
- Misses       9655     9670      +15     
+ Partials     1435     1427       -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133918e...9e6341f. Read the comment docs.

@jmhbnz
Copy link
Member

jmhbnz commented Oct 11, 2024

/retest

@jmhbnz jmhbnz merged commit e67407b into etcd-io:main Oct 11, 2024
34 checks passed
@ivanvc ivanvc deleted the remove-arm-integration-github-workflows branch October 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved github_actions Pull requests that update GitHub Actions code size/M
Development

Successfully merging this pull request may close these issues.

4 participants