github/workflows: use ECR mirror for Trivy's DB #18672
Conversation
GitHub Container Registry is returning a TOOMANYREQUESTS error. Switch to AWS ECR mirror, as suggested in aquasecurity/trivy-action#389. Signed-off-by: Ivan Valdes <[email protected]>
k8s-ci-robot
added
github_actions
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18672 +/- ##
==========================================
+ Coverage 68.70% 68.90% +0.19%
==========================================
Files 420 420
Lines 35535 35535
==========================================
+ Hits 24414 24485 +71
+ Misses 9686 9625 -61
+ Partials 1435 1425 -10 Continue to review full report in Codecov by Sentry.
|
|
It looks to work as expected, refer to: https://github.com/etcd-io/etcd/actions/runs/11150670417/job/30992575192?pr=18672#step:5:13 I'll retest the coverage (linux-amd64-coverage) test, which failed. |
|
/retest |
| # Use AWS' ECR mirror for the trivy-db image, as GitHub's Container | ||
| # Registry is returning a TOOMANYREQUESTS error. | ||
| # Ref: https://github.com/aquasecurity/trivy-action/issues/389 | ||
| TRIVY_DB_REPOSITORY: 'public.ecr.aws/aquasecurity/trivy-db:2' |
There was a problem hiding this comment.
Is there any restriction on public.ecr.aws/aquasecurity/trivy-db? @dims @chaochn47
There was a problem hiding this comment.
I thought it was okay, as there are many instances of images from the public.ecr.aws registry in the k/test-infra repo, including our website listing, as it uses an AWS ECR mirror of the NodeJS image.
Either way, it'd be great to have the blessing to use it ✌️.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-3.5 |
|
@jmhbnz: new pull request created: #18687 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-3.4 |
|
@jmhbnz: new pull request created: #18688 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
GitHub Container Registry is returning a TOOMANYREQUESTS error. Switch to AWS ECR mirror, as suggested in aquasecurity/trivy-action#389.
Part of #18671.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.