Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): document how to install stress tool #18651

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ghouscht
Copy link
Contributor

@ghouscht ghouscht commented Sep 30, 2024

Fixes #18650. I think this is all what was missing for me, should also be enough for others to help fix flaky tests.

@k8s-ci-robot
Copy link

Hi @ghouscht. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (68e7122) to head (d700f3c).
Report is 4 commits behind head on main.

Current head d700f3c differs from pull request most recent head bea695d

Please upload reports for the commit bea695d to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18651      +/-   ##
==========================================
+ Coverage   68.77%   68.80%   +0.02%     
==========================================
  Files         420      420              
  Lines       35535    35535              
==========================================
+ Hits        24440    24450      +10     
+ Misses       9660     9658       -2     
+ Partials     1435     1427       -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e7122...bea695d. Read the comment docs.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request, @ghouscht. This is looking great, I left two suggestions ✌️

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@ghouscht ghouscht requested a review from ivanvc October 1, 2024 06:08
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ghouscht. It looks good. Can you please squash your commits?

Thanks again.

@ghouscht
Copy link
Contributor Author

ghouscht commented Oct 2, 2024

Thanks, @ghouscht. It looks good. Can you please squash your commits?

Thanks again.

Sorry forgot about that but it is done now.

@ivanvc
Copy link
Member

ivanvc commented Oct 2, 2024

/retest

@ivanvc
Copy link
Member

ivanvc commented Oct 2, 2024

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Thomas.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ghouscht, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 7fa7786 into etcd-io:main Oct 3, 2024
39 checks passed
@ghouscht ghouscht deleted the issue-18650 branch October 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Document deflaking process
5 participants