-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Backport DefaultSnapshotCount 10K #18589
[3.5] Backport DefaultSnapshotCount 10K #18589
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clement2026 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @clement2026. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f612ecb
to
ca7d3d6
Compare
Signed-off-by: Clement <[email protected]>
ca7d3d6
to
8aee45e
Compare
/ok-to-test |
Don't think we should change defaults in stable releases. |
I don't insist on backporting the default value to 3.5, but it's a low hang fruit to improve the performance, and personally I do not see any risk (the only minor comment is about CPU usage change because snapshot is much more frequent against the old value) so should also be safe. It's open to the community discussion. |
cc @liggitt who has a lot of experience about stability from K8s |
Anyone who wants this benefit can already obtain it by explicitly setting If this is already overrideable by operators, I would avoid changing defaults in a backport |
I ran some benchmarks for this PR and they show higher throughput(#17098 (comment)). If we don’t have enough support to backport |
An experiment in #17098 (comment) suggests that setting a low
snapshot-count
can reduce the heap size. v3.5 might benefit from setting
DefaultSnapshotCount
to 10_000, which is already the default in v3.6.Here is a table copied from #17098 (comment), showing how heap size is affected by
--snapshot-count
and--experimental-snapshot-catchup-entries
.putSize
: average size ofput
requests-catchup-entries
v3.5.16
v3.6.0-alpha.0