-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix server_test.go #18582
tests: fix server_test.go #18582
Conversation
Hi @clement2026. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Clement <[email protected]>
6970220
to
b51d3cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #18582 +/- ##
==========================================
+ Coverage 68.73% 68.88% +0.15%
==========================================
Files 420 420
Lines 35474 35474
==========================================
+ Hits 24382 24438 +56
+ Misses 9666 9617 -49
+ Partials 1426 1419 -7 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Clement <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clement2026, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @ahrtr |
The change is simple and straightforward, but let's get #18494 (comment) clarified firstly. |
#18494 creates a non-empty raft log snapshot on server startup, which requires:
kv
is set :etcd/server/etcdserver/server.go
Lines 2132 to 2143 in 981061a
This PR fixes the failed tests in
server_test.go
by :kv
forEtcdServer
Part of #17098