-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: remove amd64 test actions #18314
Conversation
The pull-etcd-unit-test-amd64, pull-etcd-unit-test-386, pull-etcd-integration-1-cpu-amd64, pull-etcd-integration-2-cpu-amd64 and pull-etcd-integration-8-cpu-amd64 jobs are already running on the prow infrastructure. It is safe to remove these duplicated workloads from GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
Given that now the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 18 files with indirect coverage changes @@ Coverage Diff @@
## main #18314 +/- ##
==========================================
- Coverage 68.96% 68.93% -0.03%
==========================================
Files 417 417
Lines 35332 35332
==========================================
- Hits 24366 24356 -10
- Misses 9554 9558 +4
- Partials 1412 1418 +6 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @ivanvc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The pull-etcd-unit-test-amd64, pull-etcd-unit-test-386, pull-etcd-integration-1-cpu-amd64, pull-etcd-integration-2-cpu-amd64, and pull-etcd-integration-8-cpu-amd64 jobs are already running on the prow infrastructure. It is safe to remove these duplicated workloads from GitHub actions.
Fixes #18065
Part of kubernetes/k8s.io#6102
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.