-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script and workflow to detect flaky tests in testgrid. #17662
Conversation
843f977
to
8682e63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, the result is looking great 👏
I left a couple of suggestions, and I hope it's ok ✌️
Signed-off-by: Siyuan Zhang <[email protected]>
Signed-off-by: Siyuan Zhang <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for addressing my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great first iteration - thanks @siyuanfoundation
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
For #13167
Ideally this should live in the k8s test-infra or testgrid repo for it to be maintained long term. But that is a much bigger and longer effort that requires coordination with the sig-testing team.
For now, I think it is beneficial to get it running while we seek long term solution with the sig-testing team.
Example of auto created issue: siyuanfoundation#10