Skip to content

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Aug 15, 2025

This uses https://tip.golang.org/doc/modules/managing-dependencies#tools to manage and install additional tools.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrueg
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Manuel Rüger <[email protected]>
@k8s-ci-robot
Copy link

Hi @mrueg. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Aug 15, 2025

Hi, @mrueg. Thanks for the pull request. I was experimenting with the tool directive in our etcd-operator repository (etcd-io/etcd-operator@main...ivanvc:etcd-operator:use-go-1.24-tools). If I remember correctly, we could keep track of versions if you include them in requires. Did you install the tools using go get -tool? I also faced some challenges when calling go tool on a clean repository. Let's test this, and see the result of the CI.

/ok-to-test

@mrueg
Copy link
Contributor Author

mrueg commented Aug 15, 2025

@ivanc yes, with go get -tool, I don't know if you can do version pinning for go tool. In this case, @latest was used for most packages.

@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants