#284 Missing AMD definition fix in the 01-into.js.#307
Open
dfsq wants to merge 1 commit intoesvit:masterfrom
Open
#284 Missing AMD definition fix in the 01-into.js.#307dfsq wants to merge 1 commit intoesvit:masterfrom
dfsq wants to merge 1 commit intoesvit:masterfrom
Conversation
This is a missing piece of the fix for esvit#284. 01-intro.js should also be fixed otherwise this AMD definition will still be incorrect upon the project build (grunt concat task).
dfsq
referenced
this pull request
May 26, 2014
"angular || null" will return an error if angular is not defined, not null as expected this change makes ng-table compatible with requireJS (bug appeared when ng-table was loaded before angular, that can happen at random)
Collaborator
|
Is this PR still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a missing piece of the fix for #284. 01-intro.js should also be fixed otherwise this AMD definition will still be incorrect upon the project build (grunt concat task).