Relocate advanced materialization settings in workflows #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travjenkins
reviewed
Jan 17, 2025
Comment on lines
+20
to
+32
| const fullSourceErrorExists = useBindingStore((state) => { | ||
| const fullSourceErrors = state.fullSourceConfigs[bindingUUID]?.errors; | ||
|
|
||
| if (!fullSourceErrors) { | ||
| return false; | ||
| } | ||
|
|
||
| return fullSourceErrors.length > 0; | ||
| }); | ||
|
|
||
| const onIncompatibleSchemaChangeErrorExists = useBindingStore( | ||
| (state) => state.onIncompatibleSchemaChangeErrorExists.binding | ||
| ); |
There was a problem hiding this comment.
Do not need to change for this PR... but I think it would be safe to put these two into a single shallow call. I think that might help reduce how often these might change.
travjenkins
reviewed
Jan 17, 2025
Comment on lines
+934
to
+942
| setOnIncompatibleSchemaChangeErrorExists: (value, key) => { | ||
| set( | ||
| produce((state: BindingState) => { | ||
| state.onIncompatibleSchemaChangeErrorExists[key] = value; | ||
| }), | ||
| false, | ||
| 'On Incompatible Schema Change Error Exists Set' | ||
| ); | ||
| }, |
There was a problem hiding this comment.
100% do not want to handle this in the PR. However, I think we should not have scope be involved with setting this and we should eventually add this to the meta data of the binding.
That way the new fields can also show an error icon in the selector.
travjenkins
approved these changes
Jan 17, 2025
…erialization-settings
travjenkins
deleted the
kiahna-tucker/workflows/obscure-advanced-materialization-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are completely resolved by this PR:
#1416
Changes
1416
The following features are included in this PR:
Add an Advanced Options accordion section to the Source Collections form section to hide the specification-level
onIncompatibleSchemaChangefield.Add an Advanced Options accordion section at the bottom of the Config tab in the binding selector to hide the binding-level
onIncompatibleSchemaChangeand time travel fields.Update the Source Collections section description of the materialization edit workflow to the following:
The collections bound to your materialization. Update configuration under the Endpoint Config tab.This content change request is made in the linked issue.Tests
Manually tested
Approaches to testing are as follows:
Validate that the capture workflows remain unchanged.
Validate that the
onIncompatibleSchemaChangeand time travel functionality remain unchanged.Validate that the specification-level
onIncompatibleSchemaChangefield appears in the Advanced Options accordion section located within the Source Collections form section.Validate that the binding-level
onIncompatibleSchemaChangefield appears in the Advanced Options accordion section located at the bottom of the Config tab in the binding selector.Automated tests
N/A
Playwright tests ran locally
Screenshots
Materialization Create Workflow
Specification-level Advanced Options | Closed
Specification-level Advanced Options | Open
Materialization Edit Workflow
Source Collections section description in materialization edit workflow
Specification-level Advanced Options | Closed
Specification-level Advanced Options | Open
Binding-level Advanced Options | Closed
Binding-level Advanced Options | Open