Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing the schema to control the case #1360

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Allowing the schema to control the case #1360

merged 1 commit into from
Nov 12, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Nov 12, 2024 •
edited
Loading

Issues

#1359

Changes

1359

  • Do not call startCase anymore and allow the schema to have 100% control over casing

Tests

Manually tested

  • Hit a few capture and materialization create flows
  • Reviewed storage mappings forms
  • Reviewed time travel

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

image

@travjenkins travjenkins marked this pull request as ready for review November 12, 2024 14:54
@travjenkins travjenkins requested a review from a team as a code owner November 12, 2024 14:54
kiahna-tucker
kiahna-tucker approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@kiahna-tucker kiahna-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without manual testing.

@travjenkins travjenkins merged commit 38f9fe7 into main Nov 12, 2024
3 checks passed
@travjenkins travjenkins deleted the travjenkins/bug/respect-case-on-json-form-groups branch November 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker