Support dekaf materializations
#1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiahna-tucker
changed the title
dekaf endpointsdekaf materializations
…ion-endpoint-shape
kiahna-tucker
commented
Nov 7, 2024
…ion-endpoint-shape
…ion-endpoint-shape
…ion-endpoint-shape
travjenkins
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
lgtm - I just did static analysis and then ran through and made sure tons of captures and materializations were able to render
Only call out is I am not totally sure how much this new alert adds in terms of UX. I think making it clear it will require configuration on an external system is a good idea but the two alerts look a little wonky.
…ion-endpoint-shape
kiahna-tucker
deleted the
kiahna-tucker/dekaf-integration/materialization-endpoint-shape
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are advanced by this PR:
#1270
Changes
1270
The following features are included in this PR:
Tests
Manually tested
Approaches to testing are as follows:
Automated tests
Playwright tests ran locally