Adding ability for collapsible group to reset data and details graph message #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controlling accordion so we can open/close as needed
travjenkins
changed the title
travjenkins
commented
Nov 4, 2024
There was a problem hiding this comment.
Moved to a stand alone component as I think we might show this elsewhere. Also, don't need the full graph rendering more times than needed.
travjenkins
commented
Nov 4, 2024
There was a problem hiding this comment.
This is only for materializations but instead of checking for them specifically I went ahead and just based on the config. That way if we ever add these settings to other entity types then this will just work.
…emove-json-schema-objects
moving the setting of reset into the context
kiahna-tucker
approved these changes
Nov 13, 2024
travjenkins
deleted the
travjenkins/feature/remove-json-schema-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
completes #1353
completes #1352
Changes
1353
1352
Tests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
1353
Show a button with the same label
Shows enabled when there is data
Tooltip to explain
We will show two clears for different objects to keep it simple right now
1352
Show a delay message
Show default delay if we cannot parse sync OR it is
0s