Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm updates #21

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Npm updates #21

wants to merge 13 commits into from

Conversation

brettz9
Copy link

@brettz9 brettz9 commented Apr 30, 2020

  • Breaking change: Update estraverse dep.
  • License: Add separate copy of BSD-2-Clause (as per other estools project)
  • Travis: Change from stable to 10, 12, 14
  • Linting: Apply config used in other estools projects (disabling in main file until Babel routine to be added to build)
  • Docs (README): Use more current syntax in examples
  • Refactoring: Remove gulp in favor of npm scripts
  • Babel: Use "json" extension
  • npm: Add npmrc as per other estools projects
  • npm: Use files in package.json in place of .npmignore (as per other estools projects)
  • npm (package.json): Add recommended bugs and keywords fields and use author/contributors in place of maintainers
  • npm: Update to Babel 7/preset-env; update other devDeps. (chai, esprima)
  • npm: Remove unneeded babel-eslint and unused jsdoc
  • Testing: Use chai/register-expect and babel/register
  • Testing: Add coverage with nyc
  • Testing: Get to 100% coverage

Note that I've set nyc thresholds below 100% since there are still a few uncovered lines. I wasn't sure whether esrecurse should be allowing for poorly formed AST, and it seems that the remaining cases may not be reachable for invalid AST. I went ahead and added tests to fully cover current code expectations. If validation is ever desired to reject AST without normally expected properties like type, the tests can be changed.

I could submit an ESM PR though I'll await results of the discussion of estools/esutils#34 (comment) .

@Standard8
Copy link

@Constellation @michaelficarra Would it be possible to get some review / comments on this?

I just noticed that ESLint is requiring different versions of estraverse because estools/esquery has been updated, but esrecurse hasn't.

@brettz9
Copy link
Author

brettz9 commented Jul 24, 2020

Btw, I updated the devDeps. further and got to 100% coverage.

- License: Add separate copy of BSD-2-Clause (as per other estools project)
- Travis: Change from stable to 10, 12, 14
- Linting: Apply config used in other estools projects (disabling in main file until Babel routine to be added to build)
- Docs (README): Use more current syntax in examples
- Refactoring: Remove gulp in favor of npm scripts
- Babel: Use "json" extension
- npm: Add npmrc as per other estools projects
- npm: Use `files` in package.json in place of `.npmignore` (as per other estools projects)
- npm (package.json): Add recommended bugs and keywords fields and use author/contributors in place of maintainers
- npm: Update to Babel 7/preset-env; update other devDeps. (chai, esprima)
- npm: Remove unneeded babel-eslint and unused jsdoc
- Testing: Use chai/register-expect and babel/register
- Testing: Add coverage with nyc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants