fix: Allow multiple imagePullSecrets to work

[mikebryant]

Purpose

This fixes an issue where the extra indentation causes invalid yaml if 2+ imagePullSecrets are specified.

Also don't set them at all if not asked for - this fixes an issue for us where it conflicts with a kyverno ClusterPolicy that defaults our imagePullSecrets for everything, and the explicit setting of [] was causing a persistent diff in ArgoCD

Changes

Multiple image pull secrets will no longer cause a yaml error

Not setting imagepullsecrets will now template as not setting that parameter, rather than explicitly setting it to []

Testing

Tested locally:

➜  k8s-image-swapper git:(fix-image-pull-secrets) helm template . --show-only templates/serviceaccount.yaml --set 'imagePullSecrets[0].name=blah' --set 'imagePullSecrets[1].name=blah2'
---
# Source: k8s-image-swapper/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: release-name-k8s-image-swapper
  labels:
    helm.sh/chart: k8s-image-swapper-1.10.3
    app.kubernetes.io/name: k8s-image-swapper
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/component: app
    app.kubernetes.io/version: "1.5.10"
    app.kubernetes.io/managed-by: Helm

imagePullSecrets:
  - name: blah
  - name: blah2


➜  k8s-image-swapper git:(fix-image-pull-secrets) helm template . --show-only templates/serviceaccount.yaml
---
# Source: k8s-image-swapper/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: release-name-k8s-image-swapper
  labels:
    helm.sh/chart: k8s-image-swapper-1.10.3
    app.kubernetes.io/name: k8s-image-swapper
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/component: app
    app.kubernetes.io/version: "1.5.10"
    app.kubernetes.io/managed-by: Helm

Code Author Checklist

• Bump the chart version (Chart.yaml -> version)
• JSON Schema updated (values.schema.json)
• Update README.md via helm-docs (or make prep)
• Run pre-commit run --all-files via pre-commit (or make prep)
• Update Artifacthub annotation (Chart.yaml -> artifacthub.io/changes, artifacthub.io/images)

[mikebryant]

Heya @estahn, would you be able to take a look at this? :)

[estahn]

@mikebryant Looks fine. Could you fix up the helm-docs issue? Otherwise I'll do it :) ... I think if you allow commits from upstream CI should auto-fix it, but not sure.

[mikebryant]

Hmm, I do have Allow edits by maintainers checked
I've updated the other chart version, since helm-docs is changing the version number in the README. Hopefully that fixes the checks?

[mikebryant]

(Though if I've still got it wrong and you don't mind fixing it, I'd appreciate it 😄)