Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sanity check for locales #3573

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

atjn
Copy link
Contributor

@atjn atjn commented Sep 14, 2024

I have removed the old sanitycheck which ran in the frontend. I have added a more comprehensive sanitycheck library that is used in two places:

  • It runs as part of the CI sanitycheck, which means it should catch all issues before the code is merged.
  • It runs in the frontend if the user chooses to customize their locale. If it detects an issue, the user is warned about the errors, but is still allowed to upload the locale if they wish. Example:
    image

The upper limits on text length corresponds to the limits I defined in #3530

@atjn
Copy link
Contributor Author

atjn commented Sep 16, 2024

Tagging @gfwilliams so @bobrippling doesn't have to do it :)

@gfwilliams
Copy link
Member

Looks good, thanks!

I forget, but what's the deal with meridian now? It used to be that we left it undefined for countries that didn't usually include it in the time, but I guess now we're just including for everyone and leaving it up to whatever clock there is?

@gfwilliams gfwilliams merged commit 86b7952 into espruino:master Sep 16, 2024
1 check passed
@atjn
Copy link
Contributor Author

atjn commented Sep 16, 2024

I forget, but what's the deal with meridian now? It used to be that we left it undefined for countries that didn't usually include it in the time, but I guess now we're just including for everyone and leaving it up to whatever clock there is?

Yes, it should be included in all locales, as defined in #3534

@atjn atjn deleted the locale-check branch September 16, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants